-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:tag): support fully control by user #3100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3100 +/- ##
==========================================
- Coverage 97.37% 97.32% -0.06%
==========================================
Files 559 550 -9
Lines 11627 11515 -112
Branches 835 821 -14
==========================================
- Hits 11322 11207 -115
- Misses 193 199 +6
+ Partials 112 109 -3
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit 2943185 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your pr!
tslint error, plz fix it and rebase onto master
@CoderPoet ping~ Are you stilling working on this? I could take it over if you will. |
Closed due to inactivity. Please reopen another PR if you still would like to contribute. Thank you. BTW, I didn't see this feature is implemented in antd. Could you please describe the use case? |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Checkable tags now support full user control
Does this PR introduce a breaking change?
Other information